Merge pull request 'feat: enhance sparepart database queries and sparepart number validation' (#46) from wisdom into main
Reviewed-on: #46
This commit is contained in:
@@ -13,7 +13,7 @@ class SparepartService {
|
||||
static async getAllSparepart(param) {
|
||||
try {
|
||||
const results = await getAllSparepartDb(param);
|
||||
results.data.map((item) => {});
|
||||
results.data.map((item) => { });
|
||||
return results;
|
||||
} catch (error) {
|
||||
throw new ErrorHandler(error.statusCode || 500, error.message);
|
||||
@@ -39,8 +39,8 @@ class SparepartService {
|
||||
static async createSparepart(data) {
|
||||
try {
|
||||
if (!data || typeof data !== "object") data = {};
|
||||
if (data.sparepart_name) {
|
||||
const exists = await checkSparepartNameExistsDb(data.sparepart_name);
|
||||
if (data.sparepart_name && data.sparepart_number) {
|
||||
const exists = await checkSparepartNameExistsDb(data.sparepart_name, data.sparepart_number);
|
||||
if (exists)
|
||||
throw new ErrorHandler(400, "Sparepart name already exists");
|
||||
}
|
||||
@@ -48,7 +48,7 @@ class SparepartService {
|
||||
if (data.sparepart_yearly) {
|
||||
data.sparepart_yearly = JSON.stringify(data.sparepart_yearly);
|
||||
}
|
||||
|
||||
|
||||
const created = await createSparepartDb(data);
|
||||
if (!created) throw new ErrorHandler(500, "Failed to create Sparepart");
|
||||
return created;
|
||||
@@ -63,10 +63,11 @@ class SparepartService {
|
||||
if (!existing) throw new ErrorHandler(404, "Sparepart not found");
|
||||
if (
|
||||
data.sparepart_name &&
|
||||
data.sparepart_name !== existing.sparepart_name
|
||||
data.sparepart_name !== existing.sparepart_name && data.sparepart_number && data.sparepart_number !== existing.sparepart_number
|
||||
) {
|
||||
const exists = await checkSparepartNameExistsDb(
|
||||
data.sparepart_name,
|
||||
data.sparepart_number,
|
||||
id
|
||||
);
|
||||
if (exists)
|
||||
|
||||
Reference in New Issue
Block a user