diff --git a/controllers/sparepart.controller.js b/controllers/sparepart.controller.js index c6e0229..a1d5fe0 100644 --- a/controllers/sparepart.controller.js +++ b/controllers/sparepart.controller.js @@ -35,7 +35,7 @@ class SparepartController { const pathDocument = `${folder}/${file.filename}`; value.sparepart_foto = pathDocument; } - value.created_by = req.user?.user_id || null; + value.userId = req.user.user_id const results = await SparepartService.createSparepart(value); const response = await setResponse(results, 'Sparepart created successfully'); return res.status(response.statusCode).json(response); @@ -60,7 +60,7 @@ class SparepartController { const pathDocument = `${folder}/${file.filename}`; value.sparepart_foto = pathDocument; } - value.updated_by = req.user?.user_id || null; + value.userId = req.user.user_id const results = await SparepartService.updateSparepart(id, value); const response = await setResponse(results, 'Sparepart updated successfully'); res.status(response.statusCode).json(response); @@ -69,6 +69,7 @@ class SparepartController { res.status(response.statusCode).json(response); } } + static async delete(req, res) { const { id } = req.params; const results = await SparepartService.deleteSparepart(id, req.user.user_id); diff --git a/services/sparepart.service.js b/services/sparepart.service.js index 96385e4..e380091 100644 --- a/services/sparepart.service.js +++ b/services/sparepart.service.js @@ -7,7 +7,6 @@ const { checkSparepartNameExistsDb, } = require("../db/sparepart.db"); - const { ErrorHandler } = require("../helpers/error"); class SparepartService { @@ -21,20 +20,19 @@ class SparepartService { } } - static async getSparepartById(id) { - try { - const sparepart = await getSparepartByIdDb(id); + static async getSparepartById(id) { + try { + const sparepart = await getSparepartByIdDb(id); - if (!sparepart || sparepart.length === 0) { - throw new ErrorHandler(404, "Sparepart not found"); + if (!sparepart || sparepart.length === 0) { + throw new ErrorHandler(404, "Sparepart not found"); + } + + return sparepart[0]; + } catch (error) { + throw new ErrorHandler(error.statusCode || 500, error.message); } - - return sparepart[0]; - } catch (error) { - throw new ErrorHandler(error.statusCode || 500, error.message); } -} - static async createSparepart(data) { try { @@ -44,19 +42,7 @@ class SparepartService { if (exists) throw new ErrorHandler(400, "Sparepart name already exists"); } - const insertData = { - sparepart_name: data.sparepart_name, - sparepart_description: data.sparepart_description, - sparepart_foto: data.sparepart_foto, - sparepart_stok: data.sparepart_stok, - sparepart_model: data.sparepart_model, - sparepart_merk: data.sparepart_merk, - sparepart_qty: data.sparepart_qty, - sparepart_item_type: data.sparepart_item_type, - sparepart_unit: data.sparepart_unit, - created_by: data.created_by, - }; - const created = await createSparepartDb(insertData); + const created = await createSparepartDb(data); if (!created) throw new ErrorHandler(500, "Failed to create Sparepart"); return created; } catch (error) { @@ -79,20 +65,7 @@ class SparepartService { if (exists) throw new ErrorHandler(400, "Sparepart name already exists"); } - const updateData = { - sparepart_name: data.sparepart_name, - sparepart_description: data.sparepart_description, - sparepart_foto: data.sparepart_foto, - sparepart_stok: data.sparepart_stok, - sparepart_model: data.sparepart_model, - sparepart_merk: data.sparepart_merk, - sparepart_qty: data.sparepart_qty, - sparepart_item_type: data.sparepart_item_type, - sparepart_unit: data.sparepart_unit, - updated_at: data.updated_at, - updated_by: data.updated_by - }; - const updated = await updateSparepartDb(id, updateData); + const updated = await updateSparepartDb(id, data); if (!updated) throw new ErrorHandler(500, "Failed to update Sparepart"); return await this.getSparepartById(id); } catch (error) {