fixing verify access #36

Merged
bragaz_rexita merged 1 commits from wisdom into main 2026-01-08 05:38:23 +00:00
3 changed files with 26 additions and 13 deletions

View File

@@ -1,6 +1,10 @@
const { ErrorHandler } = require("../helpers/error"); const { ErrorHandler } = require("../helpers/error");
const { getUserByIdDb } = require("../db/user.db"); const { getUserByIdDb } = require("../db/user.db");
function isPhoneNumberID(phone) {
return /^(?:\+62|62|0)8[1-9][0-9]{6,10}$/.test(phone);
}
const verifyAccess = (minLevel = 1, allowUnapprovedReadOnly = false) => { const verifyAccess = (minLevel = 1, allowUnapprovedReadOnly = false) => {
return async (req, res, next) => { return async (req, res, next) => {
try { try {
@@ -11,6 +15,7 @@ const verifyAccess = (minLevel = 1, allowUnapprovedReadOnly = false) => {
// Super Admin bypass semua // Super Admin bypass semua
if (user.is_sa) return next(); if (user.is_sa) return next();
if (!isPhoneNumberID(user.user_id)) {
const fullUser = await getUserByIdDb(user.user_id); const fullUser = await getUserByIdDb(user.user_id);
if (!fullUser) throw new ErrorHandler(403, "Forbidden: User not found"); if (!fullUser) throw new ErrorHandler(403, "Forbidden: User not found");
@@ -27,6 +32,14 @@ const verifyAccess = (minLevel = 1, allowUnapprovedReadOnly = false) => {
if (!fullUser.role_level || fullUser.role_level < minLevel) { if (!fullUser.role_level || fullUser.role_level < minLevel) {
throw new ErrorHandler(403, "Forbidden: Insufficient role level"); throw new ErrorHandler(403, "Forbidden: Insufficient role level");
} }
} else {
if (req.method !== 'GET' && req.baseUrl !== '/api/notification-log') {
if (req.baseUrl !== '/api/notification') {
throw new ErrorHandler(403, "Forbidden: Insufficient Access");
}
}
}
next(); next();
} catch (err) { } catch (err) {

View File

@@ -26,7 +26,7 @@ router
.get(verifyToken.verifyAccessToken, NotificationErrorController.getById) .get(verifyToken.verifyAccessToken, NotificationErrorController.getById)
.put( .put(
verifyToken.verifyAccessToken, verifyToken.verifyAccessToken,
// verifyAccess(), verifyAccess(),
NotificationErrorController.update NotificationErrorController.update
); );

View File

@@ -9,7 +9,7 @@ router.route("/")
.get(verifyToken.verifyAccessToken, NotificationErrorLogController.getAll) .get(verifyToken.verifyAccessToken, NotificationErrorLogController.getAll)
.post( .post(
verifyToken.verifyAccessToken, verifyToken.verifyAccessToken,
// verifyAccess(), verifyAccess(),
NotificationErrorLogController.create); NotificationErrorLogController.create);
router.route("/:id") router.route("/:id")