From 3c098d1c69fba476390e368d7258ab232b236deb Mon Sep 17 00:00:00 2001 From: mhmmdafif Date: Thu, 30 Apr 2026 15:22:42 +0700 Subject: [PATCH 1/2] add: await in data filtering logic --- services/notifikasi-wa.service.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/notifikasi-wa.service.js b/services/notifikasi-wa.service.js index e74ef48..d442fb1 100644 --- a/services/notifikasi-wa.service.js +++ b/services/notifikasi-wa.service.js @@ -281,7 +281,7 @@ class NotifikasiWaService { async runReminder() { setInterval(async () => { const now = new Date(); - let data = this.loadReminder(); + let data = await this.loadReminder(); data = data?.filter(async (item) => { -- 2.49.1 From b811accc4889bd38c5682e1eb8e2c59dc36bc8ff Mon Sep 17 00:00:00 2001 From: Fachba Date: Thu, 30 Apr 2026 15:54:30 +0700 Subject: [PATCH 2/2] fix: correct device name reference in notification message and adjust error handling in reminder saving logic --- services/notifikasi-wa.service.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/services/notifikasi-wa.service.js b/services/notifikasi-wa.service.js index d442fb1..6e62092 100644 --- a/services/notifikasi-wa.service.js +++ b/services/notifikasi-wa.service.js @@ -393,6 +393,7 @@ class NotifikasiWaService { const now = new Date(); const year = now.getFullYear(); const reminderAt = new Date(deviceReminder[0].reminder_at); + const deviceName = new Date(deviceReminder[0].device_name); // 🔹 ambil bulan & jam dalam timezone server const nowParts = new Intl.DateTimeFormat('en-US', { @@ -439,7 +440,7 @@ class NotifikasiWaService { if (!checkNotifExist) { - const deviceNotification = await getSparepartsByYearlyDb(yearly); + // const deviceNotification = await getSparepartsByYearlyDb(yearly); const data = { error_code_id: yearly ?? chanel.value, @@ -455,6 +456,8 @@ class NotifikasiWaService { await this.saveReminder({ notification_log: resultNotificationError.notification_error_id, + error_code_id: data['error_code_id'], + error_chanel: data['error_chanel'], start_at: timeReminderString, interval: 1, max: 3, @@ -483,7 +486,7 @@ class NotifikasiWaService { const bodyMessage = `Hai ${dataUser.contact_name || "-"},\n` + - `Diberitahukan bahwa terdapat sparepart pada device "${deviceNotification?.device_name ?? "-"}" ` + + `Diberitahukan bahwa terdapat sparepart pada device "${deviceName ?? "-"}" ` + `yang telah memasuki jadwal perawatan tahunan.\n` + `\nSilakan segera lakukan pengecekan dan perawatan untuk memastikan kinerja tetap optimal.` + `\nDetail sparepart dapat dilihat pada link berikut:\n${shortUrl}`; -- 2.49.1